Skip to content

For gpkg file restore always use diff checkpoints#594

Merged
MarcelGeo merged 2 commits intodevelopfrom
gpgk_restore_from_checkpoints
Mar 17, 2026
Merged

For gpkg file restore always use diff checkpoints#594
MarcelGeo merged 2 commits intodevelopfrom
gpgk_restore_from_checkpoints

Conversation

@varmar05
Copy link
Collaborator

Drop legacy support to use individual 0 rank diffs. Instead always use diff checkpoints and create them recursively if needed. This change uses the same logic as we do in v2 endpoints.

Please note that reconstruction can still throw 502/504 if backend does not make it within allowed time. As each try can now take less time to finish (intermediate checkpoints created), clients can implement retry logic.

Drop legacy support to use individual 0 rank diffs. Instead always use diff checkpoints and create them recursively if needed.
This change uses the same logic as we do in v2 endpoints.
@varmar05 varmar05 requested a review from MarcelGeo March 13, 2026 15:00
@coveralls
Copy link

coveralls commented Mar 13, 2026

Pull Request Test Coverage Report for Build 23142863243

Details

  • 77 of 82 (93.9%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 94.626%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server/mergin/sync/models.py 16 21 76.19%
Totals Coverage Status
Change from base Build 22944359470: -0.02%
Covered Lines: 9103
Relevant Lines: 9620

💛 - Coveralls

Copy link
Collaborator

@MarcelGeo MarcelGeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@MarcelGeo MarcelGeo merged commit c17b8ac into develop Mar 17, 2026
4 checks passed
@MarcelGeo MarcelGeo deleted the gpgk_restore_from_checkpoints branch March 17, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants